Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move dartdoc into the sdk repo #1279

Open
devoncarew opened this issue Nov 22, 2016 · 4 comments
Open

move dartdoc into the sdk repo #1279

devoncarew opened this issue Nov 22, 2016 · 4 comments
Assignees
Labels
P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-infra A repository infrastructure change or enhancement

Comments

@devoncarew
Copy link
Member

We want to move dartdoc into the sdk repo to better participant in refactorings to the analyzer codebase.

@devoncarew devoncarew added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-infra A repository infrastructure change or enhancement labels Nov 22, 2016
@kevmoo
Copy link
Member

kevmoo commented Nov 22, 2016

Not a bad idea – we have tricks to even keep the history here, me thinks.

@jcollins-g jcollins-g added the P3 A lower priority bug or feature request label Feb 1, 2019
@srawlins
Copy link
Member

I'd like to resurrect this (it never really died 😄 ). There are some costs we'd like to avoid:

  • synchronizing breaking changes from the analyzer
  • synchronizing releases of dartdoc into the Dart SDK
  • synchronizing releases of dartdoc into google3
  • a second issue tracker for the analyzer team (could be alleviated independently by just moving the issue tracker and leaving the code)

some costs of moving to dart-lang/sdk:

  • likely much slower CI cycles :(
  • a little bit less friendly to external developers
  • not-as-varied platform trybots? Maybe not, but need to ensure there are Mac and Windows trybots

@srawlins srawlins added P2 A bug or feature request we're likely to work on and removed P3 A lower priority bug or feature request labels Mar 29, 2023
@jcollins-g
Copy link
Contributor

@srawlins I put some information about my thoughts on this here: https://docs.google.com/document/d/1wx5SiVfeWsoVCBYco1FVMo_EXWPsqnxCCsKBHNJGTYI/edit?resourcekey=0-KdbEwxHW0kEtr7oAur8ReA#heading=h.ojs0ha5yfw0

@whesse
Copy link
Contributor

whesse commented Sep 12, 2023

This can be done the same way that we migrated the linter repo into the Dart SDK repo. All the steps in that migration need to be followed here. I can add a checklist with those steps to this issue, after reviewing them.

The linter migration was tracked in dart-lang/sdk#59165

@whesse whesse self-assigned this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

No branches or pull requests

5 participants