Skip to content

extra whitespaces in 0.21.1 #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isoos opened this issue Sep 26, 2018 · 4 comments
Closed

extra whitespaces in 0.21.1 #1762

isoos opened this issue Sep 26, 2018 · 4 comments
Labels
P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@isoos
Copy link
Contributor

isoos commented Sep 26, 2018

0.21.1 introduced an extra whitespace after <span class="name">[...]</span> element blocks, e.g.
https://github.com/dart-lang/pub-dartlang-dart/pull/1650/files#diff-88fd39e0fb39d833ac45993a6424225c

@jcollins-g
Copy link
Contributor

Is the extra whitespace a more serious problem than P3?

@jcollins-g jcollins-g added P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Sep 26, 2018
@isoos
Copy link
Contributor Author

isoos commented Sep 26, 2018

P3 sounds perfect.

@jcollins-g
Copy link
Contributor

The whitespace changes are because of the categories support; there are now optional fields that will occasionally show up after identifier names inside documentation. The spaces are from the template, where there's a space between references in the template.

That can probably be eliminated, but I think it would be wise to not depend heavily on whitespace consistency between versions.

@isoos
Copy link
Contributor Author

isoos commented Sep 28, 2018

Sounds fair to me. We don't depend on the whitespaces in any way, just wanted to make sure that there was no unexpected regression.

@isoos isoos closed this as completed Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants