Skip to content

Commit 0d7ffaa

Browse files
authored
Rename comments (#373)
1 parent a3cf960 commit 0d7ffaa

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

.github/workflows/health_base.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ jobs:
197197
--experiments ${{ inputs.experiments }} \
198198
--health_yaml_name ${{ inputs.health_yaml_name }}
199199
200-
- run: test -f current_repo/output/comment.md || echo $'The ${{ inputs.check }} workflow has encountered an exception and did not complete.' >> current_repo/output/comment.md
200+
- run: test -f current_repo/output/comment-${{ inputs.check }}.md || echo $'The ${{ inputs.check }} workflow has encountered an exception and did not complete.' >> current_repo/output/comment-${{ inputs.check }}.md
201201
if: ${{ '$action_state' == 1 }}
202202

203203
- name: Upload coverage to Coveralls
@@ -214,4 +214,4 @@ jobs:
214214
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
215215
with:
216216
name: comment-${{ inputs.check }}
217-
path: current_repo/output/comment.md
217+
path: current_repo/output/comment-${{ inputs.check }}.md

pkgs/firehose/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
- Make the PR health output less verbose by collapsing warnings by default.
44
- Bump dart_apitool to fix errors with equal types being reported as different.
5+
- Give comment files in health work.
56

67
## 0.12.0
78

pkgs/firehose/lib/src/health/health.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ class Health {
6363
path.join(
6464
directory.path,
6565
'output',
66-
'comment.md',
66+
'comment-${check.displayName}.md',
6767
) {
6868
flutterExecutable =
6969
(Process.runSync('which', ['-a', 'flutter']).stdout as String)

0 commit comments

Comments
 (0)