extension type support for sort_constructors_first (#4669)

dart-archive · Aug 11, 2023 · 91ae2b6 · 91ae2b6
1 parent facc499
commit 91ae2b6
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/lib/src/rules/sort_constructors_first.dart b/lib/src/rules/sort_constructors_first.dart
@@ -54,6 +54,7 @@ class SortConstructorsFirst extends LintRule {
     var visitor = _Visitor(this);
     registry.addClassDeclaration(this, visitor);
     registry.addEnumDeclaration(this, visitor);
+    registry.addExtensionTypeDeclaration(this, visitor);
   }
 }
 
@@ -85,4 +86,9 @@ class _Visitor extends SimpleAstVisitor<void> {
   void visitEnumDeclaration(EnumDeclaration node) {
     check(node.members);
   }
+
+  @override
+  void visitExtensionTypeDeclaration(ExtensionTypeDeclaration node) {
+    check(node.members);
+  }
 }
diff --git a/test/rules/sort_constructors_first_test.dart b/test/rules/sort_constructors_first_test.dart
@@ -14,6 +14,9 @@ main() {
 
 @reflectiveTest
 class SortConstructorsFirstTest extends LintRuleTest {
+  @override
+  List<String> get experiments => ['inline-class'];
+
   @override
   String get lintRule => 'sort_constructors_first';
 
@@ -48,6 +51,19 @@ abstract class A {
     ]);
   }
 
+  test_methodBeforeConstructor_extensionType() async {
+    // Since the check logic is shared w/ classes and enums, one test should
+    // provide sufficient coverage for extension types.
+    await assertDiagnostics(r'''
+extension type E(Object o) {
+  void f() {}
+  E.e(this.o);
+}
+''', [
+      lint(45, 1),
+    ]);
+  }
+
   test_methodBeforeConstructors() async {
     await assertDiagnostics(r'''
 abstract class A {