Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code quality: use named groups in RegExp #451

Open
srawlins opened this issue Aug 30, 2022 · 0 comments
Open

code quality: use named groups in RegExp #451

srawlins opened this issue Aug 30, 2022 · 0 comments
Labels
contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) P3 A lower priority bug or feature request

Comments

@srawlins
Copy link
Member

I had totally missed that Dart RegExp supports named groups. We should use these in parsing, as it is mind-melting to try to keep the indices of nested groups in order, especially on the list item patterns.
@srawlins srawlins added contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) P3 A lower priority bug or feature request labels Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) P3 A lower priority bug or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srawlins