-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all BlockParser and InlineParser APIs public #600
Comments
Yeah I think that's fair. |
@srawlins Hi, I think you should also expose the utils, patterns etc to make more easy to create custom extensions. For example I create a extension similar to Thanks |
I'm trying to build a solution to #599 in my own package. To do that, I'm trying to define my own
InlineSyntax
, which needs to inspect the_delimiterStack
. But the_delimiterStack
is private, so I can't access it from my package, preventing me from building my ownInlineSyntax
.Any API that's needed by any
BlockSyntax
orInlineSyntax
should be public, so that the developers outside of this package don't become second-class citizens with respect to what they're allowed to access.Here's a snippet from
TagSyntax
within this package:Notice that it would be impossible for this same class to be defined from outside the package.
There's no reason to hide things from the outside world. This is a parsing package - if something is relevant for parsing, it should be public.
The text was updated successfully, but these errors were encountered: