Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge this repo into dart-lang/native #555

Closed
dcharkes opened this issue Nov 1, 2023 · 0 comments · Fixed by #545
Closed

Merge this repo into dart-lang/native #555

dcharkes opened this issue Nov 1, 2023 · 0 comments · Fixed by #545

Comments

@dcharkes
Copy link
Collaborator

dcharkes commented Nov 1, 2023

As discussed on #430, we'd like to merge this repo with dart-lang/native.

I don't believe we have to follow the history rewrite steps in dart-lang/tools#100, because this repo is already a mono-repo.

We do need the other steps from that though.

And at least one additional step:

  • toplevel readme should be moved into package:jnigen

@HosseinYousefi could you prepare a PR with the steps linked above?
@dcharkes dcharkes mentioned this issue Nov 1, 2023
Merged
auto-submit bot referenced this issue Nov 1, 2023
@dcharkes
[infra] Rename dart.yaml to native.yaml (#176)
22b6b24 
When we're going to merge in more packages into this repo, they'll have their own workflows.

So rename the current workflow to something more specific.

Context:

* https://github.com/dart-lang/jnigen/issues/410
* https://github.com/dart-lang/ffigen/issues/635
* https://github.com/dart-lang/ffi/issues/218
@HosseinYousefi HosseinYousefi mentioned this issue Nov 16, 2023
Merged
HosseinYousefi referenced this issue Nov 16, 2023
@dcharkes
[infra] Rename dart.yaml to native.yaml (#176)
df0b657 
When we're going to merge in more packages into this repo, they'll have their own workflows.

So rename the current workflow to something more specific.

Context:

* https://github.com/dart-lang/jnigen/issues/410
* https://github.com/dart-lang/ffigen/issues/635
* https://github.com/dart-lang/ffi/issues/218
@HosseinYousefi HosseinYousefi transferred this issue from dart-archive/jnigen Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge jnigen dart-lang/native
1 participant
@dcharkes