-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Score dropped from 110 to 80 #7848
Comments
Both the static analysis and the downgrade analysis is failing on the linked prerelease, and the latest stable is also failing static analysis. Do you have a custom |
Yes, but since 6 month ago, and I used to have 110 points at least.
|
As the SDKs or
|
Thanks, was aware of the dependency constraints but I still feel it's a bug drop. Can I know scores points beforehand in some way? |
You may run I've seen people running it in github CI on every commit, but for most people it is fine to just check the scores periodically and fix them. Like, in this case, fixing the dependencies. (Note again: score is a dynamic metric, depends on you, on third party dependencies and also on pub-dev). Closing this as I don't see any direct pana- or pub-dev-related item. |
Thanks @isoos ! I'll see what I can resolve! |
No problem. Feel free to reopen if you see anything weird after fixing the dependencies. |
Thanks, btw, I do depend on json_annotation https://github.com/WalletConnect/Web3ModalFlutter/blob/master/pubspec.yaml#L23 |
We don't have a formal documentation of it outside the codebase of |
Wonderful, thanks for the explanation! |
Hello @isoos! Writing here so I don't open a new issue and create more noise but let me know if you want me to open an issue. Could you explain why I keep getting analysis issues on this repo? https://pub.dev/packages/walletconnect_modal_flutter
|
@quetool: please open new issues, as the old ones are closed after a specific bug is fixed, and the new symptom may be for a new reason. In this case it seems to be a dartdoc bug though, which is not on the latest stable on pub.dev, and may have been fixed already. Unfortunately we are in the holiday season, and fixes like that may happen much slower than usual. |
I opened dart-lang/dartdoc#3826 to track this |
Is something happening with the analyzer? No way I have all of these issues in my package https://pub.dev/packages/web3modal_flutter/versions/3.3.0-beta01/score
Score dropped from 110 to 80. Can you help me address this, pointing me towards the proper direction? Thanks!
The text was updated successfully, but these errors were encountered: