Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve "formatter" as a package name #8128

Closed
munificent opened this issue Oct 9, 2024 · 2 comments
Closed

Reserve "formatter" as a package name #8128

munificent opened this issue Oct 9, 2024 · 2 comments

Comments

@munificent
Copy link
Member

At long last, we're adding support to dart format for configuring page width at the project level. The configuration goes in analysis_options.yaml under a formatter key:

formatter:
  page_width: 123

This is consistent with other top level keys in that file: analyzer and linter. In those latter cases, those keys are also the name of the package. For complicated historical reasons, the formatter's package name is dart_style not formatter. It would probably be confusing if there was a package named formatter that had nothing to do with dart format or the formatter key in analysis_options.yaml.

Is it worth marking that name as reserved? As far as I can tell, there is no package on pub with that name today.

(Long-term, it might be nice to migrate dart_style to that name but that would be a lot of work for marginal benefit.)

@sigurdm
Copy link
Contributor

sigurdm commented Oct 10, 2024

The "formatter" package name has now been reserved!

@sigurdm sigurdm closed this as completed Oct 10, 2024
@munificent
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants