Skip to content

Pub is unable to solve version contraints in some cases #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DartBot opened this issue Jun 5, 2015 · 6 comments
Closed

Pub is unable to solve version contraints in some cases #1170

DartBot opened this issue Jun 5, 2015 · 6 comments
Assignees
Labels
closed-duplicate Closed in favor of an existing report type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

Originally opened as dart-lang/sdk#21325

This issue was originally filed by luiz.mine...@gmail.com


What steps will reproduce the problem?

  1. clone https://github.com/luizmineo/dart-pub-errors
  2. run pub get in error2/test

What is the expected output? What do you see instead?

Pub should download and install all dependencies. Instead, it hangs for about 20 minutes, and exits with the follwing message:

Resolving dependencies... (13:27.3s)
Connection closed before full header was received

What version of the product are you using?

Dart 1.7.0-dev.4.6

On what operating system?

Ubuntu 14.04 x64

Please provide any additional information below.

For more details, please see issue #1163

@DartBot DartBot added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) closed-duplicate Closed in favor of an existing report Priority-Critical labels Jun 5, 2015
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2156198?v=3" align="left" width="48" height="48"hspace="10"> Comment by kasperl


Conservatively assuming that this is a release blocker.


cc @munificent.
cc @alan-knight.
cc @ricowind.
cc @whesse.
Set owner to @nex3.
Added this to the 1.7 milestone.
Removed Priority-Unassigned label.
Added Priority-Critical, Area-Pub, Accepted labels.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2156198?v=3" align="left" width="48" height="48"hspace="10"> Comment by kasperl


We should figure out if this reproduces with 1.6.x stable, 1.6.0-dev.x.x, and also the 1.7.x stable release candidates.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/3476088?v=3" align="left" width="48" height="48"hspace="10"> Comment by alan-knight


I think the only issue here is that pub could fail more gracefully in this case. I think the given constraints are unsolvable, but not in a way that's easily recognized, so it thrashes trying an exponential number of possibilities. But Nathalie is back and can speak to it much more knowledgeably.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2156198?v=3" align="left" width="48" height="48"hspace="10"> Comment by kasperl


If this is a "known" issue and it's only about failing more gracefully in case of unsolvable constraints, we need to figure out what's causing this with 1.7. Is this a regression? A change of -dev version semantics? We need to understand the implications of rolling this out to all stable channel users. Please enlighten us :-)

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/3476088?v=3" align="left" width="48" height="48"hspace="10"> Comment by alan-knight


It does not appear to be a regression or a change in semantics. If you remove the SDK constraints on 1.7-dev and loosen the stack_trace constraint which is incompatible with pub 1.6, then this reproduces in 1.6.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


This is definitely the same issue that we've seen before with pub failing poorly on an unsolvable version graph. I'm merging this into the tracking bug for that issue, and I don't think it should block the release.


Added Duplicate label.
Marked as being merged into #912.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants