Issues with deletion of stray files, persistent spamming of text and broken link

[jakemac53]

Environment

HEAD of the SDK (sha 77caf366bb002834b970f14fe9d5c085a7b11a04).

Problem A

In package:build, whenever I run a pub get, I get a large dump of text telling me it is cleaning up various files, which it isn't actually cleaning up, and it logs every single time which is annoying.

See logs

Resolving dependencies... 
Downloading packages... 
  _fe_analyzer_shared 76.0.0 (77.0.0 available)
  analyzer 6.11.0 (7.0.0 available)
  archive 3.6.1 (4.0.1 available)
  coverage 1.10.0 (1.11.1 available)
  dart_style 2.3.7 (3.0.0 available)
  json_serializable 6.8.0 (6.9.0 available)
  matcher 0.12.16+1 (0.12.17 available)
  shelf_web_socket 2.0.0 (2.0.1 available)
  test 1.25.8 (1.25.12 available)
  test_api 0.7.3 (0.7.4 available)
  test_core 0.6.5 (0.6.8 available)
  vm_service 14.3.1 (15.0.0 available)
Got dependencies!
12 packages have newer versions incompatible with dependency constraints.
Try `dart pub outdated` for more information.
Deleting old lock-file: `./build_config/pubspec.lock`.
Deleting old package config: `./build_config/.dart_tool/package_config.json`.
Deleting old lock-file: `./build_daemon/pubspec.lock`.
Deleting old package config: `./build_daemon/.dart_tool/package_config.json`.
Deleting old lock-file: `./build_modules/pubspec.lock`.
Deleting old package config: `./build_modules/.dart_tool/package_config.json`.
Deleting old lock-file: `./build_test/pubspec.lock`.
Deleting old package config: `./build_test/.dart_tool/package_config.json`.
Deleting old lock-file: `./example/pubspec.lock`.
Deleting old package config: `./example/.dart_tool/package_config.json`.
Deleting old lock-file: `./scratch_space/pubspec.lock`.
Deleting old package config: `./scratch_space/.dart_tool/package_config.json`.
Deleting old lock-file: `./tool/pubspec.lock`.
Deleting old package config: `./tool/.dart_tool/package_config.json`.
Deleting old lock-file: `./build_modules/test/fixtures/a/pubspec.lock`.
Deleting old package config: `./build_modules/test/fixtures/a/.dart_tool/package_config.json`.
Deleting old lock-file: `./build_modules/test/fixtures/pubspec.lock`.
Deleting old package config: `./build_modules/test/fixtures/.dart_tool/package_config.json`.
Deleting old lock-file: `./build_modules/test/pubspec.lock`.
Deleting old package config: `./build_modules/test/.dart_tool/package_config.json`.
Deleting old lock-file: `./build_modules/test/fixtures/b/pubspec.lock`.
Deleting old package config: `./build_modules/test/fixtures/b/.dart_tool/package_config.json`.
See https://dart.dev/go/workspaces-stray-files for details.
Resolving dependencies... 
Downloading packages... 
Got dependencies.
Deleting old lock-file: `./build_config/pubspec.lock`.
Deleting old package config: `./build_config/.dart_tool/package_config.json`.
Deleting old lock-file: `./build_daemon/pubspec.lock`.
Deleting old package config: `./build_daemon/.dart_tool/package_config.json`.
Deleting old lock-file: `./build_modules/pubspec.lock`.
Deleting old package config: `./build_modules/.dart_tool/package_config.json`.
Deleting old lock-file: `./build_test/pubspec.lock`.
Deleting old package config: `./build_test/.dart_tool/package_config.json`.
Deleting old lock-file: `./example/pubspec.lock`.
Deleting old package config: `./example/.dart_tool/package_config.json`.
Deleting old lock-file: `./scratch_space/pubspec.lock`.
Deleting old package config: `./scratch_space/.dart_tool/package_config.json`.
Deleting old lock-file: `./tool/pubspec.lock`.
Deleting old package config: `./tool/.dart_tool/package_config.json`.
Deleting old lock-file: `./build_modules/test/fixtures/a/pubspec.lock`.
Deleting old package config: `./build_modules/test/fixtures/a/.dart_tool/package_config.json`.
Deleting old lock-file: `./build_modules/test/fixtures/pubspec.lock`.
Deleting old package config: `./build_modules/test/fixtures/.dart_tool/package_config.json`.
Deleting old lock-file: `./build_modules/test/pubspec.lock`.
Deleting old package config: `./build_modules/test/.dart_tool/package_config.json`.
Deleting old lock-file: `./build_modules/test/fixtures/b/pubspec.lock`.
Deleting old package config: `./build_modules/test/fixtures/b/.dart_tool/package_config.json`.
See https://dart.dev/go/workspaces-stray-files for details.

Expected behavior

I expect to see these logs only one time ever (per package checkout), and only for files which actually need to be deleted.

Actual behavior

This happens every single time you run pub get, and it is never actually cleaning anything up at all - these files do not exist.

You will also notice it seems to be doing everything twice.

Problem B

The link listed at the end, https://dart.dev/go/workspaces-stray-files, is a 404 page.

[sigurdm]

The link is being created here: sigurdm/site-www#1

[sigurdm]

Thanks for spotting this!