Merge pull request dart-archive/linter#3589 from scheglov/analyzer-4.5.0

Require analyze 4.5.0, stop using deprecated APIs.

Author: bwilkerson

lib/src/ast.dart

@@ -156,7 +156,7 @@ bool isPrivate(Token? name) =>
 
 /// Returns `true` if the given [ClassMember] is a public method.
 bool isPublicMethod(ClassMember m) {
-  var declaredElement = m.declaredElement;
+  var declaredElement = m.declaredElement2;
   return declaredElement != null && isMethod(m) && declaredElement.isPublic;
 }
 
@@ -277,7 +277,7 @@ bool _checkForSimpleGetter(MethodDeclaration getter, Expression? expression) {
   if (expression is SimpleIdentifier) {
     var staticElement = expression.staticElement;
     if (staticElement is PropertyAccessorElement) {
-      var enclosingElement = getter.declaredElement?.enclosingElement3;
+      var enclosingElement = getter.declaredElement2?.enclosingElement3;
       // Skipping library level getters, test that the enclosing element is
       // the same
       if (staticElement.enclosingElement3 == enclosingElement) {

lib/src/extensions.dart

@@ -226,16 +226,12 @@ extension InterfaceTypeExtension on InterfaceType {
 extension MethodDeclarationExtension on MethodDeclaration {
   /// Returns whether this method is an override of a method in any supertype.
   bool get isOverride {
-    var parent = this.parent;
-    if (parent is! ClassOrMixinDeclaration) {
-      return false;
-    }
-    var name = declaredElement?.name;
+    var name = declaredElement2?.name;
     if (name == null) {
       return false;
     }
-    var parentElement = parent.declaredElement;
-    if (parentElement == null) {
+    var parentElement = declaredElement2?.enclosingElement3;
+    if (parentElement is! InterfaceElement) {
       return false;
     }
     var parentLibrary = parentElement.library;

lib/src/rules/annotate_overrides.dart

@@ -100,14 +100,14 @@ class _Visitor extends SimpleAstVisitor<void> {
     if (node.isStatic) return;
 
     for (var field in node.fields.variables) {
-      check(field.declaredElement, field.name2);
+      check(field.declaredElement2, field.name2);
     }
   }
 
   @override
   void visitMethodDeclaration(MethodDeclaration node) {
     if (node.isStatic) return;
 
-    check(node.declaredElement, node.name2);
+    check(node.declaredElement2, node.name2);
   }
 }

lib/src/rules/avoid_classes_with_only_static_members.dart

@@ -78,7 +78,7 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   @override
   void visitClassDeclaration(ClassDeclaration node) {
-    var declaredElement = node.declaredElement;
+    var declaredElement = node.declaredElement2;
     if (declaredElement == null) {
       return;
     }

lib/src/rules/avoid_equals_and_hash_code_on_mutable_classes.dart

@@ -108,7 +108,7 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   ClassElement? _getClassForMethod(MethodDeclaration node) =>
       // todo (pq): should this be ClassOrMixinDeclaration ?
-      node.thisOrAncestorOfType<ClassDeclaration>()?.declaredElement;
+      node.thisOrAncestorOfType<ClassDeclaration>()?.declaredElement2;
 
   bool _hasImmutableAnnotation(ClassElement clazz) {
     var inheritedAndSelfElements = <InterfaceElement>[

lib/src/rules/avoid_field_initializers_in_const_classes.dart

@@ -104,7 +104,7 @@ class _Visitor extends SimpleAstVisitor<void> {
     // only const class
     var parent = node.parent;
     if (parent is ClassDeclaration) {
-      var declaredElement = parent.declaredElement;
+      var declaredElement = parent.declaredElement2;
       if (declaredElement == null) {
         return;
       }

lib/src/rules/avoid_init_to_null.dart

@@ -105,7 +105,7 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   @override
   void visitVariableDeclaration(VariableDeclaration node) {
-    var declaredElement = node.declaredElement;
+    var declaredElement = node.declaredElement2;
     if (declaredElement != null &&
         !node.isConst &&
         !node.isFinal &&

lib/src/rules/avoid_positional_boolean_parameters.dart

@@ -63,7 +63,7 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   @override
   void visitConstructorDeclaration(ConstructorDeclaration node) {
-    var declaredElement = node.declaredElement;
+    var declaredElement = node.declaredElement2;
     if (declaredElement != null && !declaredElement.isPrivate) {
       var parametersToLint =
           node.parameters.parameters.where(_isFormalParameterToLint);
@@ -75,7 +75,7 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   @override
   void visitFunctionDeclaration(FunctionDeclaration node) {
-    var declaredElement = node.declaredElement;
+    var declaredElement = node.declaredElement2;
     if (declaredElement != null && !declaredElement.isPrivate) {
       var parametersToLint = node.functionExpression.parameters?.parameters
           .where(_isFormalParameterToLint);
@@ -87,7 +87,7 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   @override
   void visitMethodDeclaration(MethodDeclaration node) {
-    var declaredElement = node.declaredElement;
+    var declaredElement = node.declaredElement2;
     if (declaredElement != null &&
         !node.isSetter &&
         !declaredElement.isPrivate &&

lib/src/rules/avoid_renaming_method_parameters.dart

@@ -84,7 +84,7 @@ class _Visitor extends SimpleAstVisitor<void> {
     if (parentNode is! Declaration) {
       return;
     }
-    var parentElement = parentNode.declaredElement;
+    var parentElement = parentNode.declaredElement2;
     // Note: there are no override semantics with extension methods.
     if (parentElement is! ClassElement) {
       return;

lib/src/rules/avoid_returning_null.dart

@@ -91,7 +91,7 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   @override
   void visitMethodDeclaration(MethodDeclaration node) {
-    var declaredElement = node.declaredElement;
+    var declaredElement = node.declaredElement2;
     if (declaredElement != null &&
         _isPrimitiveType(declaredElement.returnType)) {
       _visitFunctionBody(node.body);