Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[beta][vm] Fix DateTime.timeZoneName on Windows
It needs to look at the given moment to decide whether to use summer time zone name or standard time zone name. Previously it was looking at the current time to make this decision which produced incorrect result: e.g. given `DateTime.parse(2012-01-02T13:45:23)` its `timeZoneName` should be returning standard name corresponding to the current time zone even if we are currently running in summer time (e.g. it should return PST if machine it is running on is in PDT). This is revealed by a test which started to fail on Windows because our Windows bots entered PDT. Fixes #55159 TEST=corelib/date_time7_test.dart CoreLibraryReviewExempt: No core library changes. Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/356681 Cherry-pick-request: #55240 Change-Id: I11fb963ec90055db168c7f34bdf7c58229085bd1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/358440 Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Kevin Chisholm <kevinjchisholm@google.com>
- Loading branch information