Skip to content

Commit

Permalink
[benchmark] Don't pass --sound-null-safety to dart_precompiled_runtime2.
Browse files Browse the repository at this point in the history
The autodetection was fixed in bbc8aed,
so the workaround of passing --sound-null-safety to the AOT runtime is
no longer needed.

This change tests that the autodetection does in fact work.

Bug: #42421
Change-Id: Ibbe9665905e817a28964b698e6c437897c9dc6ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153771
Reviewed-by: Alexander Markov <alexmarkov@google.com>
  • Loading branch information
sortie committed Jul 9, 2020
1 parent 9a4e2b1 commit c84c1cb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/bots/try_benchmarks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ EOF
DART_CONFIGURATION=ReleaseX64 pkg/vm/tool/precompiler2 --packages=.packages hello.dart blob.bin
DART_CONFIGURATION=ReleaseX64 pkg/vm/tool/dart_precompiled_runtime2 --profile-period=10000 blob.bin
DART_CONFIGURATION=ReleaseX64 pkg/vm/tool/precompiler2 --sound-null-safety --enable-experiment=non-nullable --packages=.packages hello.dart blob.bin
DART_CONFIGURATION=ReleaseX64 pkg/vm/tool/dart_precompiled_runtime2 --sound-null-safety --profile-period=10000 blob.bin
DART_CONFIGURATION=ReleaseX64 pkg/vm/tool/dart_precompiled_runtime2 --profile-period=10000 blob.bin
out/ReleaseX64/dart --profile-period=10000 --packages=.packages --optimization-counter-threshold=-1 hello.dart
out/ReleaseX64/dart-sdk/bin/dart2js --packages=.packages --out=out.js -m hello.dart
third_party/d8/linux/x64/d8 --stack_size=1024 sdk/lib/_internal/js_runtime/lib/preambles/d8.js out.js
Expand Down

0 comments on commit c84c1cb

Please sign in to comment.