[infra] Disallow spaces in test configuration names

Change-Id: Ibd96e414d9a8c76a36b4fc8360ceca3560f1dd91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181404
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>

Author: whesse

pkg/smith/lib/configuration.dart

@@ -381,7 +381,12 @@ class Configuration {
         useHotReload = useHotReload ?? false,
         useHotReloadRollback = useHotReloadRollback ?? false,
         useSdk = useSdk ?? false,
-        useQemu = useQemu ?? false;
+        useQemu = useQemu ?? false {
+    if (name.contains(" ")) {
+      throw ArgumentError(
+          "Name of test configuration cannot contain spaces: $name");
+    }
+  }
 
   /// Returns `true` if this configuration's options all have the same values
   /// as [other].

pkg/smith/test/configuration_test.dart

@@ -303,7 +303,7 @@ void main() {
       );
 
       var debugWithAsserts2 = Configuration(
-        "different name",
+        "different-name",
         Architecture.x64,
         Compiler.dart2js,
         Mode.debug,

pkg/test_runner/lib/src/options.dart

@@ -854,7 +854,7 @@ compiler.''',
             for (var sanitizerName in sanitizers.split(",")) {
               var sanitizer = Sanitizer.find(sanitizerName);
               var configuration = Configuration(
-                  "custom configuration_${configurationNumber++}",
+                  "custom-configuration-${configurationNumber++}",
                   architecture,
                   compiler,
                   mode,