Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn me if I use @observable without extends Object with ObservableMixin #12357

Closed
sethladd opened this issue Aug 9, 2013 · 8 comments
Closed
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug
Milestone

Comments

@sethladd
Copy link
Contributor

sethladd commented Aug 9, 2013

It would help certain users such as myself to be warned if they (me) use @­observable without also putting extends Object with ObservableMixin

@sigmundch
Copy link
Member

=), this is basically what this TODO is all about:
https://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/pkg/observe/lib/transform.dart#­148

I initially had more warnings, but it would have had false negatives (e.g. if you extend from Observable indirectly). So for now we only report a warning if there isn't a base class or mixin.

We could fix that if we did more work with the analyzer (resolving types and such).

@sethladd
Copy link
Contributor Author

sethladd commented Sep 6, 2013

cc @sigmundch.
Added Library-PolymerLinter label.

@sigmundch
Copy link
Member

Added this to the M8 milestone.

@sigmundch
Copy link
Member

Removed this from the M8 milestone.
Added this to the Later milestone.

@sigmundch
Copy link
Member

Removed this from the Later milestone.
Added this to the M9 milestone.

@clayberg
Copy link

Removed this from the M9 milestone.
Added this to the 1.1 milestone.

@sigmundch
Copy link
Member

Removed this from the 1.1 milestone.
Added this to the 1.2 milestone.

@jmesserly
Copy link

if anything I think we're more likely to go the dirty-checking fallback route:
https://code.google.com/p/dart/issues/detail?id=16342


Added NotPlanned label.

@sethladd sethladd added Type-Enhancement closed-not-planned Closed as we don't intend to take action on the reported issue labels May 14, 2014
@sethladd sethladd added this to the 1.2 milestone May 14, 2014
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed priority-unassigned labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants