Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some inheritance errors have been been changed to be warnings #12386

Closed
jwren opened this issue Aug 12, 2013 · 3 comments
Closed

Some inheritance errors have been been changed to be warnings #12386

jwren opened this issue Aug 12, 2013 · 3 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@jwren
Copy link
Member

jwren commented Aug 12, 2013

Some errors are now warnings, see https://code.google.com/p/dart/issues/detail?id=11497

Affected tests in tests/language directory:

class_override_negative_test
bad_override_test/06
@jwren
Copy link
Member Author

jwren commented Aug 12, 2013

Removed Area-Language label.
Added Area-Test label.

@ricowind
Copy link
Contributor

Hey Jamie,
What more explicitly needs to be fixed here?

cc @peter-ahe-google.
cc @mkustermann.

@jwren
Copy link
Member Author

jwren commented Aug 13, 2013

+regis

Good question! It appears that by the time you looked at it, a CL had landed already that resolved this issue: https://codereview.chromium.org//22685007

@jwren jwren added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Aug 13, 2013
@iarkh iarkh mentioned this issue Oct 27, 2018
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwren @ricowind