Hint about non-useful concat being possible typo

[stevemessick]

I could wish for a hint when I'm concatenating adjacent strings together when it's at least possible I mean something else. e.g.

  path.join(path.dirname(scriptDir), 'doc' 'sdk-introduction.md');

where the method I'm calling at least has the ability to take an additional parameter, and I'm concatenating two constant strings on the same line, which really doesn't gain me anything.

Alan Knight
////////////////////////////////////////////////////////////////////////////////////
Editor: 1.0.0_r30187 (2013-11-12)
OS: Mac OS X - x86_64 (10.8.5)
JVM: 1.6.0_65

projects: 3

open dart files: 45

auto-run pub: false
localhost resolves to: 127.0.0.1
mem max/total/free: 1983 / 681 / 246 MB
thread count: 48
index: 702637 relationships in 142552 keys in 604 sources

SDK installed: true
Dartium installed: true

[lrhn]

I guess you'd want a warning for the case where two string literals are adjacent and:

• one the same line
• with the same quotes/rawness/multilineness
  That is, when they could be combined without any issue.

[clayberg]

Added Analyzer-Hint label.

[kasperl]

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

[kasperl]

Removed Oldschool-Milestone-Later label.

[alan-knight]

Issue #13844 has been merged into this issue.

[srawlins]

This has the strong possibility of yielding false positives. Should this be a linter instead? Similar to #57318.