-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VM stack traces can include blank lines #15920
Comments
The stack_trace package now includes a workaround for this. |
Set owner to @zanderso. |
Looking at Stacktrace::ToCStringInternal(), since all of the constant and format strings end with newlines only after non-zero characters are printed, it appears to me to be impossible that the blank line in the above mentioned stack trace was generated there. |
It's possible I'm misreading the output, but it certainly looks like a blank line. Have you tried reproducing it against 1.1.0-dev.5.0 using the steps outlined in issue #15709? |
My guess would be that the blank line is the tail end of the output "Connection closed before full header was received", and that the error message "Couldn't parse VM stack trace line 'null'" refers literally to a string reading 'null', rather than to an empty string, which would have yielded the error message "Couldn't parse VM stack trace line ''" if I am reading the source correctly. |
This is very puzzling. I've tried to reproduce this with the literal stack trace string from issue #15709, but the error message is different: "Couldn't parse VM stack trace line ''." Looking through the code I can't see where a null value or a literal null string would be appearing. Since issue #15709 doesn't seem to be reproducing anymore (nor can I reproduce it against 1.1.0-dev.5.0), I'm going to close this out. I'll re-open if I see this again and can track it down further. Added CannotReproduce label. |
I'm not sure how to reproduce this, but comment 12 on issue #9 ( contains an example from a user of a stack trace with a blank line (between #6 and #7). This is unhelpful for users and causes problems with the stack_trace package.
The text was updated successfully, but these errors were encountered: