Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM stack traces can include blank lines #15920

Closed
nex3 opened this issue Jan 6, 2014 · 6 comments
Closed

VM stack traces can include blank lines #15920

nex3 opened this issue Jan 6, 2014 · 6 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. closed-cannot-reproduce Closed as we were unable to reproduce the reported issue

Comments

@nex3
Copy link
Member

nex3 commented Jan 6, 2014

I'm not sure how to reproduce this, but comment 12 on issue #9 ( contains an example from a user of a stack trace with a blank line (between #­6 and #­7). This is unhelpful for users and causes problems with the stack_trace package.

@nex3
Copy link
Member Author

nex3 commented Jan 7, 2014

The stack_trace package now includes a workaround for this.

@iposva-google
Copy link
Contributor

Set owner to @zanderso.
Removed Priority-Unassigned label.
Added Priority-Medium, Accepted labels.

@zanderso
Copy link
Member

zanderso commented Jan 7, 2014

Looking at Stacktrace::ToCStringInternal(), since all of the constant and format strings end with newlines only after non-zero characters are printed, it appears to me to be impossible that the blank line in the above mentioned stack trace was generated there.

@nex3
Copy link
Member Author

nex3 commented Jan 7, 2014

It's possible I'm misreading the output, but it certainly looks like a blank line. Have you tried reproducing it against 1.1.0-dev.5.0 using the steps outlined in issue #15709?

@zanderso
Copy link
Member

zanderso commented Jan 7, 2014

My guess would be that the blank line is the tail end of the output "Connection closed before full header was received", and that the error message "Couldn't parse VM stack trace line 'null'" refers literally to a string reading 'null', rather than to an empty string, which would have yielded the error message "Couldn't parse VM stack trace line ''" if I am reading the source correctly.

@nex3
Copy link
Member Author

nex3 commented Jan 8, 2014

This is very puzzling. I've tried to reproduce this with the literal stack trace string from issue #15709, but the error message is different: "Couldn't parse VM stack trace line ''." Looking through the code I can't see where a null value or a literal null string would be appearing.

Since issue #15709 doesn't seem to be reproducing anymore (nor can I reproduce it against 1.1.0-dev.5.0), I'm going to close this out. I'll re-open if I see this again and can track it down further.


Added CannotReproduce label.

@nex3 nex3 added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. closed-cannot-reproduce Closed as we were unable to reproduce the reported issue labels Jan 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. closed-cannot-reproduce Closed as we were unable to reproduce the reported issue
Projects
None yet
Development

No branches or pull requests

3 participants