You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Still, if you regress on performance, it means that the Symbol.validated constructor (the only thing that changed) is now slower.
It's not surprising, since we did increase the complexity of the validation in order to detect more/all invalid inputs, but I would not expect it to be very significant.
Especially with dart2js code, the RegExp should be fast enough.
Angular's Parser test appears to have regressed in:
http://chromegw.corp.google.com/i/client.dart/builders/dart2js-drt-linux-1-2-be/builds/1715
Repro command is:
python tools/test.py -mrelease -cdart2js -rdrt --use-sdk --write-debug-log --write-test-outcome-log --checked -t120 pkg/third_party/angular_tests/browser_test/core/parser/parser
CL which introduced the regression appears to be:
https://codereview.chromium.org//140643006
Reverting this CL appears to fix the issue.
The text was updated successfully, but these errors were encountered: