Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge r37254 to branches/1.4 to fix dart2js type inference issue #19383

Closed
kasperl opened this issue Jun 12, 2014 · 3 comments
Closed

merge r37254 to branches/1.4 to fix dart2js type inference issue #19383

kasperl opened this issue Jun 12, 2014 · 3 comments
Assignees
@ricowind
Labels
merge-to-stable type-task A well-defined stand-alone task web-dart2js
Milestone
1.4

Comments

@kasperl
Copy link

kasperl commented Jun 12, 2014

This fixes issue #18836 and issue #18717 which caused dart2js to sometimes infer wrong types leading to non-working generated JavaScript code.

This merged cleanly with:
svn merge -c 37254 branches/bleeding_edge branches/1.4
@kasperl
Copy link
Author

kasperl commented Jun 12, 2014

Still waiting for confirmation that r37254 solves the issue so marking this as Waiting for now. I've filed this issue so we don't forget about it.

Added Waiting label.

@kasperl
Copy link
Author

kasperl commented Jun 16, 2014

Looks good to go.

Added Accepted label.

@kasperl
Copy link
Author

kasperl commented Jun 16, 2014

Fixed in r37348 (version 1.4.3).

Added Fixed label.

@kasperl kasperl added this to the 1.4 milestone Jun 16, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricowind ricowind

Labels
merge-to-stable type-task A well-defined stand-alone task web-dart2js
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
2 participants
@kasperl @ricowind