-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[next] Dart should allow cross frame dom access to windows from the same origin. #20146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Issue #19123 has been merged into this issue. |
Issue #18657 has been merged into this issue. |
Is it expected that a List allocated with the same-origin-cross-frame-window context's constructor behaves as a List? In JavaScript: > var a = new (document.getElementById('myIframe').contentWindow.Array)(5) |
Issue #20407 has been merged into this issue. |
Issue #20216 has been merged into this issue. |
Stephen: how would your example materialize in Dart? Can we ever get a hold of a native object whose constructor is another frame's Array? |
Issue #9224 has been merged into this issue. |
Issue #20944 has been merged into this issue. |
This comment was originally written by @zoechi Friendly ping. Any plans to address this? |
This comment was originally written by @Emasoft This is a major security flaw of javascript. Dart should allow it, but it should also offer improved security over javascript. |
Assigning to Terry, since his changes may cause this to happen. Set owner to @terrylucas. |
See also 17936, possibly these should be combined. Changed the title to: "[next] Dart should allow cross frame dom access to windows from the same origin.". |
Issue #19715 has been merged into this issue. |
Added Accepted label. |
Bumping into this issue in a multi window chrome app. This is a dumb restriction. Wasted 3 days so far. Thinking of jumping to TypeScript. |
Blocker for me. |
I really hope this will be fixed with the next Dartium version due in the next weeks. |
I think that Dartium in 1.13 actually returns a Window rather than a WindowBase for a cross-frame Window. That isn't so much an intentional change as an unintended consequence of going via JS Interop and not inserting the matching type conversion. So what is it you're looking to see fixed in Dartium? At this point the primary effort on Dartium is rolling to a current Chrome version. @Jop-V can you be more specific about what's blocking you? I don't think dart2js behaviour has changed. But it should still be possible to work around this fairly easily by accessing in JS. |
I want to write comment here, because we need solve this issue. DART is very good language and we are pleased to work in it. We work on large application and we need build some content of page inside iframe. We use little hack, but from DART 1.14 there is new bug. And we are also limited by other bugs in JS interop and dart2js. thank you for great work |
We currently only allow limited access to the cross-frame windows. JavaScript allows complete access - so long as the window is from the same origin. We should just match JavaScript.
At the moment, folks are just using dart:js to circumvent this restriction, so we're not really achieving anything with this.
This change will a fair bit of work - at least the following:
The text was updated successfully, but these errors were encountered: