Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript platform does not distinguish between int and double values #21198

Closed
eernstg opened this issue Oct 1, 2014 · 2 comments
Closed
Labels
closed-duplicate Closed in favor of an existing report web-dart2js

Comments

@eernstg
Copy link
Member

eernstg commented Oct 1, 2014

It is a well-known and long lasting problem that the Javacript virtual machine representation of both int and double values is Javascript numbers (double). As a result, tests requiring a run-time distinction between those two types of variables will fail. This is not expected to change soon, and hence several requests have been made to the co19 team to test for a different pair of types whenever possible. Still, some tests are all about testing this distinction, and for them it does not make sense to test with a different pair of types. Hence, a small set of tests in this category will continue to fail for an unknown (and non-trivial) amount of time.

This ticket has been created as a kind of container for those tests: If/when the Javascript platform starts supporting the int/double distinction at run-time, success of these tests should be achieved, but until then we will ignore these tests, just marking them with the number of this issue in the status file.

@DartBot
Copy link

DartBot commented Oct 3, 2014

This comment was originally written by @Emasoft


Dart should advertise itself as featuring true distinction between int and doubles at runtime (if executed natively).
This is one of the main advantages of Dart against Javascript. Of course tests should be aware of the context, and expecting the correct results only when Dart is run natively, not when compiled by dart2js.

@eernstg
Copy link
Member Author

eernstg commented Oct 6, 2014

It turns out that the right place to handle this topic is 1533, where the topic has been discussed for quite a while. I'm closing this issue as a duplicate of issue #1533, please take the discussion there.


Added Duplicate label.
Marked as being merged into #1533.

@eernstg eernstg added Type-Defect web-dart2js closed-duplicate Closed in favor of an existing report labels Oct 6, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report web-dart2js
Projects
None yet
Development

No branches or pull requests

3 participants