Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Platform::ResolveExecutablePath really needed? Not cross platform. #24302

Closed
mulander opened this issue Sep 6, 2015 · 1 comment
Closed
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-io

Comments

@mulander
Copy link

mulander commented Sep 6, 2015

The way Platform::ResolveExecutablePath is not cross platform and currently not possible to implement in a reliable way on OpenBSD.

This seems to be used to obtain the Dart SDK root:

OpenBSD Developers state that they have no safe way to obtain that info:

If the code is only used to obtain the SDK path then I think it should be part of installation configuration not part of the runtime.

This issue is related to the porting efforts of getting Dart running on OpenBSD: #10260

@kevmoo kevmoo added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io labels Sep 7, 2015
@iposva-google
Copy link
Contributor

Thanks for raising this concern about OpenBSD.

If OpenBSD really does not allow you to figure out the path a binary has been launched from, then you might need to prescribe the one and only location where the Dart SDK has to be installed for OpenBSD. Since this obviously prevents the side-by-side installation of multiple Dart SDKs on a single machine, we will not hard-code the path in general.

Ideally you will allow this to be overridden on the command line or through an environment variable. I am closing this report as I do not see any action to be taken by the Dart SDK here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-io
Projects
None yet
Development

No branches or pull requests

3 participants