Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.packages: Move resource lookup & loading to a package and deprecate Resource class #24463

Closed
mit-mit opened this issue Sep 29, 2015 · 8 comments
Closed

.packages: Move resource lookup & loading to a package and deprecate Resource class #24463

mit-mit opened this issue Sep 29, 2015 · 8 comments
Assignees
@lrhn
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
Milestone
1.14

Comments

@mit-mit
Copy link
Member

mit-mit commented Sep 29, 2015

#19430 will introduce support for getting the package root. Based on that we should move the implementation of what is in the Resource class into a package, and discontinue the Resource class.
@mit-mit mit-mit added this to the 1.13 milestone Sep 29, 2015
@mit-mit mit-mit added the area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. label Sep 29, 2015
@mit-mit mit-mit mentioned this issue Oct 1, 2015
Closed
@sethladd
Copy link
Contributor

sethladd commented Oct 5, 2015

Related: #24499

@sethladd sethladd changed the title Move resource lookup & loading to a package and discontinue Resource class Move resource lookup & loading to a package and deprecate Resource class Oct 5, 2015
@sethladd sethladd mentioned this issue Oct 5, 2015
Closed
@sethladd
Copy link
Contributor

sethladd commented Oct 6, 2015

resource package placeholder created, @lrhn is an uploader: https://pub.dartlang.org/packages/resource

@mit-mit
Copy link
Member Author

mit-mit commented Oct 7, 2015

CR: https://codereview.chromium.org/1374953002/

@mit-mit
Copy link
Member Author

mit-mit commented Oct 14, 2015

And the CR for the package: https://codereview.chromium.org/1387163002/

@mit-mit mit-mit changed the title Move resource lookup & loading to a package and deprecate Resource class .packages: Move resource lookup & loading to a package and deprecate Resource class Oct 20, 2015
@kevmoo
Copy link
Member

kevmoo commented Oct 22, 2015

Resource class is deprecated in 1.13 – keeping this open for 1.14 to track work on the package

@kevmoo kevmoo modified the milestones: 1.14, 1.13 Oct 22, 2015
@mit-mit
Copy link
Member Author

mit-mit commented Jan 14, 2016

@kevmoo, we should land this now, right?

@lrhn
Copy link
Member

lrhn commented Jan 14, 2016

As soon as the necessary functionality is landed in the VM, yes.

@mit-mit
Copy link
Member Author

mit-mit commented Jan 15, 2016

This was landed in dart-archive/resource@527b11d; closing.

@mit-mit mit-mit closed this as completed Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrhn lrhn

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
Projects
None yet
Milestone
1.14
Development

No branches or pull requests
4 participants
@sethladd @kevmoo @lrhn @mit-mit