Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM Issue TBD: broken Angular2 build #24553

Closed
kevmoo opened this issue Oct 11, 2015 · 7 comments
Closed

DOM Issue TBD: broken Angular2 build #24553

kevmoo opened this issue Oct 11, 2015 · 7 comments
Assignees
@yjbanov
Milestone
1.13

Comments

@kevmoo
Copy link
Member

kevmoo commented Oct 11, 2015

See angular/angular#4467

@yjbanov Can you provide details here? It seems that 1.13.0-dev.6.0 hasn't resolved things yet, either

CC @tbosch
@kevmoo kevmoo added this to the 1.13 milestone Oct 11, 2015
@kevmoo kevmoo mentioned this issue Oct 11, 2015
Closed
@yjbanov
Copy link

yjbanov commented Oct 13, 2015

The tests seem to fail due to DOM issues. Can't tell exactly yet what the issue is, but all failing tests attempt to access DOM in some way.

@kevmoo kevmoo changed the title Tracking: fix issue which broken Angular2 build DOM Issue TBD: broken Angular2 build Oct 13, 2015
@kevmoo
Copy link
Member Author

kevmoo commented Oct 13, 2015

...and again https://travis-ci.org/angular/angular/builds/85189153

@kevmoo
Copy link
Member Author

kevmoo commented Oct 13, 2015

Seems like we're gold – see https://travis-ci.org/angular/angular/builds/85189153

We'll have a get a couple of patches into Angular, though

@harryterkelsen
Copy link
Contributor

The patches for dart:profiler are already out:
dart-archive/di.dart#225
dart-archive/angular.dart#1742

@kevmoo
Copy link
Member Author

kevmoo commented Oct 14, 2015

I have a pull request out that turns dev channel back on angular/angular#4745

Blocked by the patches above (from @hterkelsen )

@kevmoo
Copy link
Member Author

kevmoo commented Oct 14, 2015

Both above patches have landed. Trying another build https://travis-ci.org/angular/angular/builds/85439407

@kevmoo
Copy link
Member Author

kevmoo commented Oct 15, 2015

Fixed! angular/angular#4467

@kevmoo kevmoo closed this as completed Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yjbanov yjbanov

Labels
None yet
Projects
None yet
Milestone
1.13
Development

No branches or pull requests
3 participants
@kevmoo @yjbanov @harryterkelsen