Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart2js ssa: Stack overflow from recursion into sister HBlockInformation #24635

Closed
rakudrama opened this issue Oct 20, 2015 · 1 comment
Closed
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@rakudrama
Copy link
Member

dart_extra/big_allocation_expression_test.dart fails with the SSA backend.

Code generation is expressed as a visitor on both HInstructions (to assemble JavaScript expressions), and HBlockInformation (to assemble control flow expressions like ?: and &&).
It appears when processing control flow for ?: it walks into the 'continuation' of the expression recursively, making the stack depth be O(cfg nodes).

Adding a @noinline() annotation lets the file compile.

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed Type-Defect labels Mar 1, 2016
@rakudrama
Copy link
Member Author

Fixed by 887e733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Development

No branches or pull requests

2 participants