Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please merge a4bfe1f1c7db2ad0ad71a277af5644b7e93a97d to dev #24826

Closed
whesse opened this issue Nov 4, 2015 · 1 comment
Closed

Please merge a4bfe1f1c7db2ad0ad71a277af5644b7e93a97d to dev #24826

whesse opened this issue Nov 4, 2015 · 1 comment
Milestone

Comments

@whesse
Copy link
Contributor

whesse commented Nov 4, 2015

This fixes an error in a pub test.

Merge commit a4bfe1f

The CL description is
dart2js: do typechecking even if suppressWarnings is on
this is necessary because the type of elements will not be
set unless the typechecker runs on the element. You need
the type to be set even when suppressWarnings is on because
in checked mode it is an error to declare a compiled constant
with inconsistent field types

and it is a one-line change.
See issue #24825

@whesse whesse added this to the 1.13 milestone Nov 4, 2015
@whesse
Copy link
Contributor Author

whesse commented Nov 4, 2015

Merged in 1.13.0-dev.7.9

@whesse whesse closed this as completed Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant