Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analyzer: Allow read-only access to initializing formals by default #27895

Closed
eernstg opened this issue Nov 24, 2016 · 5 comments
Closed

analyzer: Allow read-only access to initializing formals by default #27895

eernstg opened this issue Nov 24, 2016 · 5 comments
Assignees
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@eernstg
Copy link
Member

eernstg commented Nov 24, 2016

This is the analyzer specific issue for #27891; please refer to that issue for additional information.

@eernstg
Copy link
Member Author

eernstg commented Nov 24, 2016

When ready, please remove the DartOptions directives from the tests,

tests/language/initializing_formal_*_test.dart
tests/language/parameter_initializer5_test.dart

such that it will be tested that the affected tools (the analyzer and dart2js) actually enable initializing formal access without the --initializing-formal-access flag. I haven't removed these directives because it would break the analyzer, but dart2js will work both with and without them as soon as https://codereview.chromium.org/2141023002/ is landed, which should be within a day.

@floitschG floitschG added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Nov 27, 2016
@bwilkerson bwilkerson added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Nov 28, 2016
@bwilkerson bwilkerson self-assigned this Nov 28, 2016
@bwilkerson
Copy link
Member

This is enabled by default as of https://codereview.chromium.org/2532953004/.

I have not yet updated the tests.

@eernstg
Copy link
Member Author

eernstg commented Nov 30, 2016

I can see that https://codereview.chromium.org/2532953004/ was committed as 7e067a6. Thanks! I'll mark the analyzer subtask as done on #27891 now, because developers do not depend on the test updates to use this feature.

@eernstg
Copy link
Member Author

eernstg commented Nov 30, 2016

@bwilkerson, please close this one when the tests have been updated (I believe that's the only missing piece---otherwise please indicate what else is missing).

@bwilkerson
Copy link
Member

The tests were updated here: https://codereview.chromium.org/2540843002/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

3 participants