-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crash in dart::TypeParameter::set_parameterized_class #28072
Comments
cc @a-siva |
It looks like |
Never mind. These functions should work as long as the |
Apply the patch from flutter/flutter#7235 to a local Flutter checkout and run the |
Apparently, the snapshot reader/writer does not like kIllegalCid. I replaced it with kFunctionCid. There is a good chance that this landed CL fixes this issue: |
This was hit internally as 34087655 (standalone vm) and 34131149 (flutter) if anyone is following along at home. |
Attempting to verify, I did pull'd hixie's PR:
Ran Then moved to 1.22.0.-dev.4.0:
But now failed differently (likely due to this being based on a 20+ day old copy of flutter):
|
|
I think the AnalysisOptionsProcess thing is a question for @pq . |
Are you changing to a new version of the engine? Or of the local dart SDK? |
@Hixie I've only changed the local flutter/flutter dart_sdk. Here is my repo: |
That error looks like a mismatch between the version of analyzer API used in the flutter source and what's in the summary/SDK. IRC |
Since the new failure is not related to the subject of this issue, and since this issue has now been verified, I am closing it. |
Trying to run the Flutter tool after all the generic type parameter comments have been turned into real type parameters crashes:
See also the logs here: https://travis-ci.org/flutter/flutter/builds/183108649
The text was updated successfully, but these errors were encountered: