Please add toHexString to crypto lib

[sethladd]

Now that we have crypto libs appearing (thanks!) I want to ask for toHexString to be added to the crypto library. This is functionality that almost everyone has to write when using hashes like SHA1 or SHA256.

In fact, this function is copied twice in the tests for crypto:

http://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/tests/lib/crypto/sha256_test.dart?spec=svn7145&r=7145

http://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/tests/lib/crypto/sha1_test.dart?spec=svn7145&r=7145

Here's the function:

String digestToString(List<int> digest) {
  var buf = new StringBuffer();
  for (var part in digest) {
    buf.add("${(part < 16) ? "0" : ""}${part.toRadixString(16).toLowerCase()}");
  }
  return buf.toString();
}

Please add this directly to the crypto library. Developers will thank you! :)

[madsager]

Set owner to @madsager.
Added Accepted label.

[madsager]

The crypto library now has a CryptoUtils class for utilities.

CryptoUtils.bytesToHex(List<int> bytes);

---

Added Fixed label.

[sethladd]

Thanks! Curious, why didn't we use a top level function? Typing bytesToHex is much easier than CryptoUtils.bytesToHex

[madsager]

I thought it would be nice to group these utils together, but we could make it a top level function if people prefer.

[DartBot]

This comment was originally written by ladicek@gmail.com

---

I personally think that doing http://dartbug.com/2875 is even better :-)