Compiler error converted to warning in section 7.5.2: Factories

[gbracha]

This used to be a compile time error:

It is a static warning if M is not the name of the immediately enclosing class or the name of an interface in the enclosing lexical scope.

Once the typechecker reports this as a warning, the error can be removed from dart2js.

[kasperl]

Set owner to @karlklose.
Added this to the M1 milestone.
Marked this as being blocked by #3078.
Unmarked this as being blocked by #3078.

[karlklose]

It is not possible to resolve such a factory and thus dart2js never analyzes it. (The same is true for the VM.)

@gilad: please reopen if you think that we should warn about it.

---

cc @gbracha.
Added WontFix label.

[gbracha]

The language has changed so much since May that this bug is obsolete. However, there is a requirement to give an error for a factory constructor whose name does not start with the name of the enclosing class:

class Foo{
  factory Bar.make(){return new Bar();} // compile-time error
}

Now, if no one ever calls this, you never compile it and that is ok. However, if it gets called, it is an error, If the compiler is used during development (as opposed to deployment) there needs to be a way to force everything to get compiled. Right now we rely on the analyzer for this.