Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove int64 overflow checking in Integer::New #31600

Closed
sjindel-google opened this issue Dec 11, 2017 · 2 comments
Closed

Remove int64 overflow checking in Integer::New #31600

sjindel-google opened this issue Dec 11, 2017 · 2 comments
Assignees
@alexmarkov
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@sjindel-google
Copy link
Contributor

This code exists only to support the Flutter-int64 experiment, and will be dead before Dart 2.0 ships.
@sjindel-google sjindel-google added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Dec 11, 2017
@sjindel-google sjindel-google added this to the 2.0 milestone Dec 11, 2017
@dgrove
Copy link
Contributor

dgrove commented Mar 18, 2018

Is this code still live?

@alexmarkov
Copy link
Contributor

Yes, this code is still live. It is useful as long as old VM parser is used. After removing old VM parser, these overflow checks can be turned into assertions.

So, I think this issue is a part of post-Dart 2 cleanup and it is not a prerequisite to shipping Dart 2.

@alexmarkov alexmarkov removed this from the 2.0 milestone Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexmarkov alexmarkov

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dgrove @alexmarkov @sjindel-google