Skip to content

move flutter analyze off of the task model #32478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
devoncarew opened this issue Mar 9, 2018 · 10 comments
Closed

move flutter analyze off of the task model #32478

devoncarew opened this issue Mar 9, 2018 · 10 comments
Assignees
@devoncarew
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. customer-flutter P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
Dart2Beta4

Comments

@devoncarew
Copy link
Member

Context here: #32421

There are three modes that flutter analyze runs in, and one of them is still on the analyzer's task model. That's presenting issues; this bug tracks the work to move flutter analyze off the task model.
@devoncarew devoncarew added P1 A high priority bug; for example, a single project is unusable or has many test failures area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. customer-flutter labels Mar 9, 2018
@devoncarew devoncarew added this to the I/O Beta 3 milestone Mar 9, 2018
This was referenced Mar 9, 2018
Closed
Closed
@bwilkerson bwilkerson modified the milestones: Dart2 Beta 3, Dart2 Beta 4 Apr 2, 2018
@devoncarew
Copy link
Member Author

PR in progress: flutter/flutter#16281

@devoncarew
Copy link
Member Author

done

@devoncarew devoncarew reopened this Apr 11, 2018
@devoncarew
Copy link
Member Author

re-opening this - I may have to revert the flutter PR

@dgrove
Copy link
Contributor

dgrove commented Apr 20, 2018

Any updates?

@devoncarew
Copy link
Member Author

@scheglov has landed several performance improvements for the flutter analyze --flutter-repo use case - analyzing 29 separate, related packages with the main one making heavy use of exports.

We're in the process of setting up a golem test that will benchmark flutter analyze --flutter-repo (@sortie) using a combined view of commits from dart-lang/sdk and flutter/flutter.

We'll then look at re-landing the PR to refactor flutter analyze, and likely need to re baseline the benchmark as part of that. @Hixie, I'll reach out to you about that likely in this coming week

@dgrove
Copy link
Contributor

dgrove commented Apr 30, 2018

any further updates?

@devoncarew
Copy link
Member Author

Round 2 is out for review, will likely land tomorrow, and we'll then watch how things go (it's a large refactor).

@dgrove
Copy link
Contributor

dgrove commented May 3, 2018

This is flutter/flutter#16979 ?

@devoncarew
Copy link
Member Author

Yup, that's the one.

@devoncarew
Copy link
Member Author

landed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devoncarew devoncarew

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. customer-flutter P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
Dart2Beta4
Development

No branches or pull requests
3 participants
@devoncarew @dgrove @bwilkerson