Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several unit test failures in pkg_tested/dart_style/test/formatter_test when the analyzer is switched to --use-fasta-parser #34040

Closed
devoncarew opened this issue Jul 31, 2018 · 5 comments
Assignees

Comments

@devoncarew
Copy link
Member

./tools/test.py -m release -c none -r vm --checked --no-preview-dart-2 --use-sdk pkg_tested/dart_style/test/formatter_test

I see 4 unit test failures here, many with the message "Could not format because the source could not be parsed:".

@bwilkerson
Copy link
Member

@danrubel in case the parser failures are interesting

@danrubel
Copy link

As of today, all but 3 are fixed. Working on them...

@danrubel
Copy link

dart formatter changes:

@danrubel
Copy link

Blocked on dart-lang/dart_style#725

@devoncarew
Copy link
Member Author

fixed I believe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants