Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE: Support UI as code constructs in const collections #36278

Closed
kmillikin opened this issue Mar 20, 2019 · 3 comments
Closed

CFE: Support UI as code constructs in const collections #36278

kmillikin opened this issue Mar 20, 2019 · 3 comments
Assignees
@askeksa-google
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. front-end-fasta P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
Dart 2.3

Comments

@kmillikin
Copy link

The UI as code constructs need to be supported in const collections.
@kmillikin kmillikin added P1 A high priority bug; for example, a single project is unusable or has many test failures area-front-end Use area-front-end for front end / CFE / kernel format related issues. labels Mar 20, 2019
@kmillikin kmillikin added this to the Dart2.3 milestone Mar 20, 2019
@kmillikin kmillikin mentioned this issue Mar 25, 2019
Closed
3 tasks
@kmillikin
Copy link
Author

We are expecting to deliver basic support (enough for backend implementation) by March 29. Some of the static errors might still need to be implemented in the week after that.

@askeksa-google
Copy link

askeksa-google commented Mar 28, 2019 •
edited
Loading

Basic support for spread and if in const lists, sets and maps have landed as of https://dart-review.googlesource.com/c/sdk/+/98141.

There is a known problem with set and map spreads for VM targets, where it complains that the object is not a set/map. This is caused by interference from set desugaring and map constant lowering. I am working on a fix.

@askeksa-google
Copy link

Remaining issue is covered by #36387.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@askeksa-google askeksa-google

Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. front-end-fasta P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
Dart 2.3
Development

No branches or pull requests
2 participants
@kmillikin @askeksa-google