Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vm/ffi] Remove deprecated methods before D26 #38860

Closed
dcharkes opened this issue Oct 14, 2019 · 4 comments
Closed

[vm/ffi] Remove deprecated methods before D26 #38860

dcharkes opened this issue Oct 14, 2019 · 4 comments
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-ffi
Milestone

Comments

@dcharkes
Copy link
Contributor

Before we ship D26, we should remove deprecated methods from the dart:ffi API:

In order to be able to deprecate these at all in the sdk, we need to update the packages that are pulled in by DEPS (package:ffi and package:tflite_native).

We might also want to think about fixing g3.

cc @mkustermann @sjindel-google

@dcharkes dcharkes added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-ffi labels Oct 14, 2019
@dcharkes dcharkes added this to the D26 Release milestone Oct 14, 2019
@vsmenon
Copy link
Member

vsmenon commented Oct 15, 2019

If this is D26, can someone take ownership?

@sjindel-google
Copy link
Contributor

I believe Daco is already working on this.

@mkustermann
Copy link
Member

mkustermann commented Oct 15, 2019

The main cl/121422 is up and reviewed. Removing the deprecated methods depends on that one.

It's blocked on getting our github mirror working again atm.

We'll try to use github directly in the mean time to bypass this broken mirror issue.

@dcharkes
Copy link
Contributor Author

https://dart-review.googlesource.com/c/sdk/+/121708 CL ready, but blocked by CL addressing #38611.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-ffi
Projects
None yet
Development

No branches or pull requests

4 participants