Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopwatch should use window.performance.now if available #4312

Closed
jmesserly opened this issue Aug 1, 2012 · 6 comments
Closed

Stopwatch should use window.performance.now if available #4312

jmesserly opened this issue Aug 1, 2012 · 6 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug web-libraries Issues impacting dart:html, etc., libraries
Milestone

Comments

@jmesserly
Copy link

From the mailing list:

Just looking at code using Stopwatch and noticed it doesn't use window.performance.now if it's available. Couldn't find an issue for it so thought to ask what people's thoughts were regarding its use? (hoping for a one-off test rather than a per-use test)

Reference:
http://updates.html5rocks.com/2012/05/requestAnimationFrame-API-now-with-sub-millisecond-precision

jmesserly: this should give precision on the VM (because it uses Clock), but dart2js Clock uses JS Date.now(), which I think is only millisecond precision.

@kasperl
Copy link

kasperl commented Sep 3, 2012

Removed Area-Dart2JS label.
Added Area-Library label.

@sethladd
Copy link
Contributor

sethladd commented Sep 3, 2012

See also issue #1881

@sethladd
Copy link
Contributor

sethladd commented Sep 3, 2012

Moving this to Area-HTML because it's specifically talking about HTML implementation of stopwatch.

This would be a nice change.


cc @rakudrama.
Removed Type-Defect, Area-Library labels.
Added Type-Enhancement, Area-HTML labels.

@vsmenon
Copy link
Member

vsmenon commented Sep 5, 2012

Added this to the M2 milestone.

@efortuna
Copy link
Contributor

From what I can tell, there is no HTML-specific implementation of stopwatch


Set owner to @efortuna.

@efortuna
Copy link
Contributor

Fixed in r 15343 with CL: https://codereview.chromium.org//11417110


Added Fixed label.

@jmesserly jmesserly added Type-Enhancement web-libraries Issues impacting dart:html, etc., libraries labels Nov 26, 2012
@jmesserly jmesserly added this to the M2 milestone Nov 26, 2012
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

6 participants