Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow type arguments on annotations #44931

Closed
a-siva opened this issue Feb 9, 2021 · 2 comments
Closed

allow type arguments on annotations #44931

a-siva opened this issue Feb 9, 2021 · 2 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-enhancement A request for a change that isn't a bug
Milestone
March Beta Release

Comments

@a-siva
Copy link
Contributor

a-siva commented Feb 9, 2021

allow type arguments on annotations per dart-lang/language#1297 in the VM.
@a-siva a-siva added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-enhancement A request for a change that isn't a bug labels Feb 9, 2021
@a-siva a-siva added this to the March Beta Release milestone Feb 9, 2021
@a-siva
Copy link
Contributor Author

a-siva commented Feb 9, 2021

/cc @alexmarkov @crelier

@a-siva a-siva mentioned this issue Feb 9, 2021
Closed
@mkustermann
Copy link
Member

I don't think there is anything to be done on the VM side (VM just reads constants which already support type arguments). The work is on the CFE side - which only requires deleting 3 lines of code there.

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
March Beta Release
Development

No branches or pull requests
2 participants
@mkustermann @a-siva