Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement non-function type alias support in the VM/AOT #44954

Closed
leafpetersen opened this issue Feb 11, 2021 · 5 comments
Closed

Implement non-function type alias support in the VM/AOT #44954

leafpetersen opened this issue Feb 11, 2021 · 5 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. language-nonfunction-type-aliases Issues related to non-function type aliases

Comments

@leafpetersen
Copy link
Member

This issue tracks support of the non-function type alias feature. See the enclosing meta-issue for details.

I don't expect much work here, but we should validate that debugging/error messages work as desired, and that the backend doesn't choke.

cc @a-siva @mkustermann @mraleph @eernstg @mit-mit @franklinyow

@leafpetersen leafpetersen added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Feb 11, 2021
@leafpetersen leafpetersen added this to the March Beta Release milestone Feb 11, 2021
@a-siva
Copy link
Contributor

a-siva commented Feb 19, 2021

As indicated by you there is no work in the VM for implementing this feature as the front end will account for substituting the type alias.
With regards to debugging/error messages working as desired, what is the expectation? I believe currently for all typedefs the VM only shows the substituted type, this is probably true for DDC too.

@leafpetersen
Copy link
Member Author

I have no particular expectations, this issue is just to provide a sign off point for us to validate that the backend doesn't choke, and that any desired functionality is implemented.

I think that showing the substituted type in error messages is fine.

I don't know how much of these are directly VM related, but things that I can imagine being worth validating:

  • Hot reload works in a reasonable manner if a typedef is edited, or a use of a typedef is edited
  • Debugging works in a reasonable manner (i.e. doesn't crash)
  • Global type optimizations aren't confused by uses of typedefs (if everything gets substituted away early, that should be trivially true)

Basically, whenever you're comfortable with the native backend support for this feature, feel free to close this out.

@eernstg eernstg added the language-nonfunction-type-aliases Issues related to non-function type aliases label Feb 23, 2021
@leafpetersen
Copy link
Member Author

@a-siva should I close this out or is there any work we have planned here?

@a-siva
Copy link
Contributor

a-siva commented Mar 13, 2021

I had it open just to ensure that the tests passed once CFE completed the implementation.

@a-siva
Copy link
Contributor

a-siva commented Mar 22, 2021

Closing this as no work is necessary in the VM, we will track all individual test failures by opening fresh issues for each failure.

@a-siva a-siva closed this as completed Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. language-nonfunction-type-aliases Issues related to non-function type aliases
Projects
None yet
Development

No branches or pull requests

3 participants