Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement non-function type alias support in language/co19 tests #44964

Closed
leafpetersen opened this issue Feb 11, 2021 · 6 comments
Closed

Implement non-function type alias support in language/co19 tests #44964

leafpetersen opened this issue Feb 11, 2021 · 6 comments
Assignees
@eernstg
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). language-nonfunction-type-aliases Issues related to non-function type aliases
Milestone
March Beta Release

Comments

@leafpetersen
Copy link
Member

This issue tracks support of the non-function type alias feature. See the enclosing meta-issue for details.

cc @franklinyow @eernstg @mit-mit
@leafpetersen leafpetersen added this to the March Beta Release milestone Feb 11, 2021
@leafpetersen leafpetersen mentioned this issue Feb 11, 2021
Closed
19 tasks
@eernstg eernstg closed this as completed Feb 12, 2021
@eernstg eernstg reopened this Feb 12, 2021
@eernstg
Copy link
Member

eernstg commented Feb 12, 2021

@sgrekhov, @iarkh, what is the current status?

@eernstg eernstg mentioned this issue Feb 12, 2021
Closed
3 tasks
@sgrekhov
Copy link
Contributor

@eernstg we have non-function type aliases tests in co19. We simply need to enable these tests in .status files. Do you want me to do it now?

@eernstg
Copy link
Member

eernstg commented Feb 16, 2021

@sgrekhov, yes please!

@sgrekhov
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/185082

@eernstg
Copy link
Member

eernstg commented Feb 18, 2021

I'll make sure that we have language tests for cyclicity.

@franklinyow franklinyow added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Feb 18, 2021
@eernstg eernstg added the language-nonfunction-type-aliases Issues related to non-function type aliases label Feb 23, 2021
@eernstg
Copy link
Member

eernstg commented Mar 9, 2021

Type alias cyclicity tests landed as https://dart-review.googlesource.com/186290.

@eernstg eernstg closed this as completed Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eernstg eernstg

Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). language-nonfunction-type-aliases Issues related to non-function type aliases
Projects
None yet
Milestone
March Beta Release
Development

No branches or pull requests
4 participants
@sgrekhov @leafpetersen @eernstg @franklinyow