Skip to content

[dart2js] Implement enhanced support for constant factory constructors #46987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eernstg opened this issue Aug 24, 2021 · 6 comments
Closed

[dart2js] Implement enhanced support for constant factory constructors #46987

eernstg opened this issue Aug 24, 2021 · 6 comments
Assignees
@fishythefish
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. web-dart2js

Comments

@eernstg
Copy link
Member

eernstg commented Aug 24, 2021

This is the dart2js specific issue for #46984, which has the details.
@eernstg eernstg added web-dart2js area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. labels Aug 24, 2021
@eernstg eernstg mentioned this issue Aug 24, 2021
Closed
7 tasks
@sigmundch
Copy link
Member

I don't believe there is anything to do on the backend side once the CFE is changed. @fishythefish feel free to close this if/when that's the case

@eernstg
Copy link
Member Author

eernstg commented Aug 24, 2021

/cc @sigmundch, @fishythefish.

@eernstg
Copy link
Member Author

eernstg commented Aug 24, 2021

OK, sounds good!

@fishythefish
Copy link
Member

Closing since I'm not aware of any required work on our end and I don't seem to have any problems running dart-lang/language#1763, which I assume means the CFE fix must have landed already. If there are tests I should validate against, please let me know.

@eernstg
Copy link
Member Author

eernstg commented Aug 25, 2021

Maybe check that it works for the test added in https://dart-review.googlesource.com/c/sdk/+/211140?

@fishythefish
Copy link
Member

Yup, that test also runs fine for me, so considering this closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fishythefish fishythefish

Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fishythefish @sigmundch @eernstg