Skip to content

[DDC] Implement enhanced support for constant factory constructors #46988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eernstg opened this issue Aug 24, 2021 · 3 comments
Closed

[DDC] Implement enhanced support for constant factory constructors #46988

eernstg opened this issue Aug 24, 2021 · 3 comments
Assignees
@nshahan
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. web-dev-compiler

Comments

@eernstg
Copy link
Member

eernstg commented Aug 24, 2021

This is the DDC specific issue for #46984, which has the details.
@eernstg eernstg added web-dev-compiler area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. labels Aug 24, 2021
@eernstg eernstg mentioned this issue Aug 24, 2021
Closed
7 tasks
@sigmundch
Copy link
Member

I don't believe there is anything to do on the backend side once the CFE is changed. @nshahan feel free to close this if/when that's the case

@eernstg
Copy link
Member Author

eernstg commented Aug 26, 2021

@nshahan, tests/language/const/factory_member_test.dart has landed now, and it succeeds on all configurations including dartdevk-, so it looks good. Do you see any reason to keep this open?

@nshahan
Copy link
Contributor

nshahan commented Sep 3, 2021

Looks like the DDC implementation is working to me.

@nshahan nshahan closed this as completed Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nshahan nshahan

Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sigmundch @nshahan @eernstg