Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP] Merge fix for dynamic table in separate debugging ELF files #47316

Closed
sstrickl opened this issue Sep 29, 2021 · 1 comment
Closed

[CP] Merge fix for dynamic table in separate debugging ELF files #47316

sstrickl opened this issue Sep 29, 2021 · 1 comment
Labels
cherry-pick-approved Label for approved cherrypick request

Comments

@sstrickl
Copy link
Contributor

commit(s) to merge: d16ad3d

merge instructions: merges cleanly into origin/stable

What is the issue: Dynamic table in separate debugging information ELF file has invalid relocated addresses when segments are loaded into memory.

What is the fix: NOBITS sections, which have no file content to load into segments, are now ordered in segments after sections that do have content.

Why cherrypick: The bad dynamic table information impacts tools that handle the separate debugging information like Sentry.

Risk: None.

Link to original issue(s): #47289

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @devoncarew

@sstrickl sstrickl added the cherry-pick-review Issue that need cherry pick triage to approve label Sep 29, 2021
@sstrickl sstrickl changed the title [CP] Please add descriptive title for the pick here [CP] Merge fix for dynamic table in separate debugging ELF files Sep 29, 2021
@athomas
Copy link
Member

athomas commented Sep 29, 2021

Merged to stable in 020b3ef (2.14.3).

@athomas athomas closed this as completed Sep 29, 2021
@devoncarew devoncarew added cherry-pick-approved Label for approved cherrypick request and removed cherry-pick-review Issue that need cherry pick triage to approve labels Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Label for approved cherrypick request
Projects
None yet
Development

No branches or pull requests

3 participants