Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] fix certificate loading in presence of expired certificates on Windows #47432

Closed
aam opened this issue Oct 11, 2021 · 7 comments
Closed

[CP] fix certificate loading in presence of expired certificates on Windows #47432

aam opened this issue Oct 11, 2021 · 7 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request merge-to-stable os-windows

Comments

@aam
Copy link
Contributor

aam commented Oct 11, 2021

commit(s) to merge: aa0a441

merge instructions: clean merge

What is the issue: Correct certificate is not loaded in presence of similar, but expired certificate

What is the fix: Skip over expired certificates, don't load them.

Why cherrypick: Users report https-connectivity problems despite having valid certificates, caused by expired certificates

Risk: low

Link to original issue(s): #47420, #46370

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @a-siva
@aam aam added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. os-windows cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable labels Oct 11, 2021
@devoncarew
Copy link
Member

devoncarew commented Oct 11, 2021 •
edited
Loading

@aam - just to confirm - this is intended to be a merge to stable?

@devoncarew
Copy link
Member

ah, nevermind

@aam
Copy link
Contributor Author

aam commented Oct 11, 2021 •
edited
Loading

@aam - just to confirm - this is intended to be a merge to stable?

Yeah, just added appropriate label. Thanks for checking.

@devoncarew
Copy link
Member

@a-siva - can you comment on the cherry pick request (risk, impact, thumbs up/down)?

@a-siva
Copy link
Contributor

a-siva commented Oct 11, 2021

@a-siva - can you comment on the cherry pick request (risk, impact, thumbs up/down)?

risk : low (CL was submitted on Aug 26th and has already rolled into Flutter), has unit test case.
impact : addresses couple of customer reported issues ( dart-lang/pub#2990 and #47420)

lgtm for cherry pick.

@vsmenon
Copy link
Member

vsmenon commented Oct 12, 2021

lgtm

@devoncarew devoncarew added cherry-pick-approved Label for approved cherrypick request and removed cherry-pick-review Issue that need cherry pick triage to approve labels Oct 12, 2021
@mit-mit mit-mit mentioned this issue Oct 13, 2021
Closed
@athomas
Copy link
Member

athomas commented Oct 13, 2021

Cherry-picked to stable in 4ac35a7 (2.14.4).

@athomas athomas closed this as completed Oct 13, 2021
@ben-xx ben-xx mentioned this issue Oct 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request merge-to-stable os-windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@aam @devoncarew @vsmenon @a-siva @athomas