[CP] Ensure spawnUri'ed isolates keep their own origin_id. #47696
Labels
area-vm
Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
cherry-pick-approved
Label for approved cherrypick request
Comments
mkustermann
added
area-vm
|
@mkustermann given that this was found on the stable release, are you requesting this to be picked into 2.14 stable or 2.15 beta (so that it goes out with 2.15)? |
|
@athomas Given the new stable will happen soon, I think it's enough for it to be included in 2.15 beta. |
|
approved |
devoncarew
added
cherry-pick-approved
|
Merged to beta in 52519ea (2.15.0-268.18.beta). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
commit(s) to merge: c4a07a8
merge instructions: clean (auto)merge
What is the issue: An isolate spawned via
Isolate.spawnUri()that spawns another isolate viaIsolate.spawnUri()and tries to communicate with the former using user-defined data structures can lead to a crash. Instead it should result in an error. (When usingdart test/dart run- which internally usesspawnUri(), onespawnUriin user code is enough to trigger it).What is the fix: Make setting of the
origin_idof an isolate conditional on it not beingILLEGAL _PORT.Why cherrypick: Users have hit this.
Risk: low
Link to original issue(s):
#47674
/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @devoncarew
/cc @aam
The text was updated successfully, but these errors were encountered: