Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMOptions directive is ignored in generated tests #483

Closed
crelier opened this issue Nov 16, 2011 · 7 comments
Closed

VMOptions directive is ignored in generated tests #483

crelier opened this issue Nov 16, 2011 · 7 comments
Assignees
@sgjesse
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@crelier
Copy link
Contributor

crelier commented Nov 16, 2011

If the line
// VMOptions=--enable_type_checks
appears in a template test such as language/TypeVariableBoundsTest,
it gets copied to the generated tests (this is fine). However, the generated tests are not invoked with the expected --enable_type_checks flag.
@ghost
Copy link

ghost commented Nov 16, 2011

Set owner to @peter-ahe-google.
Added Area-Test, Triaged labels.

@peter-ahe-google
Copy link
Contributor

Why was this assigned to me?

Set owner to @sgmitrovic.

@iposva-google
Copy link
Contributor

cc @kasperl.
Set owner to @peter-ahe-google.

@iposva-google
Copy link
Contributor

Assigned to Peter who authored the generated tests.

Added Accepted label.

@kasperl
Copy link

kasperl commented Nov 18, 2011

Set owner to @kasperl.

@sgjesse
Copy link
Contributor

sgjesse commented Nov 24, 2011

Set owner to @sgjesse.

@sgjesse
Copy link
Contributor

sgjesse commented Nov 24, 2011

Fixed in http://codereview.chromium.org/8679025/.

Added Fixed label.

@crelier crelier added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Nov 24, 2011
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgjesse sgjesse

Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sgjesse @kasperl @iposva-google @peter-ahe-google @crelier