Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart2js should treat throw as an expression #4874

Closed
gbracha opened this issue Aug 31, 2012 · 16 comments
Closed

dart2js should treat throw as an expression #4874

gbracha opened this issue Aug 31, 2012 · 16 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Milestone

Comments

@gbracha
Copy link
Contributor

gbracha commented Aug 31, 2012

Per issue #587

@kasperl
Copy link

kasperl commented Oct 8, 2012

Set owner to ngeoffray@google.com.

@kasperl
Copy link

kasperl commented Oct 8, 2012

Removed this from the M1 milestone.
Added this to the Later milestone.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Removed this from the Later milestone.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Added this to the M2 milestone.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Marking this as high priority, but we still need to resolve how to deal with this.


Removed Priority-Medium label.
Added Priority-High label.

@munificent
Copy link
Member

I just noticed that this is still open. It's marked as an M2 issue. Do you know if we're planning to do anything here?

@DartBot
Copy link

DartBot commented Dec 10, 2012

This comment was originally written by ngeoffray@google.com


https://codereview.chromium.org/11497009

For now, rethrow is not treated as an expression, just like the VM. We might revisit the language spec and the implementations for a different milestone.

@kasperl
Copy link

kasperl commented Dec 12, 2012

Removed this from the M2 milestone.
Added this to the M3 milestone.

@johnniwinther
Copy link
Member

Issue #6086 has been merged into this issue.

@kasperl
Copy link

kasperl commented Feb 4, 2013

Issue #8261 has been merged into this issue.

@DartBot
Copy link

DartBot commented Feb 19, 2013

This comment was originally written by ngeoffray@google.com


Removed this from the M3 milestone.
Added this to the M4 milestone.

@peter-ahe-google
Copy link
Contributor

Issue #8626 has been merged into this issue.

@DartBot
Copy link

DartBot commented Apr 12, 2013

This comment was originally written by @mhausner


Rethrow is a statement. VM implementes it as of r21371. Language tests need to be converted from throw; -> rethrow;

@kasperl
Copy link

kasperl commented Apr 22, 2013

Removed this from the M4 milestone.
Added this to the M5 milestone.

@kasperl
Copy link

kasperl commented Apr 23, 2013

CL out for review: https://codereview.chromium.org/14211008/.


Set owner to @kasperl.
Added Started label.

@kasperl
Copy link

kasperl commented Apr 24, 2013

Fixed in r21930.


Added Fixed label.

@gbracha gbracha added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js labels Apr 24, 2013
@gbracha gbracha added this to the M5 milestone Apr 24, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Projects
None yet
Development

No branches or pull requests

6 participants