Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP] DDC Test and builder configuration changes #51483

Closed
nshahan opened this issue Feb 22, 2023 · 2 comments
Closed

[CP] DDC Test and builder configuration changes #51483

nshahan opened this issue Feb 22, 2023 · 2 comments
Assignees
Labels
area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). cherry-pick-denied Label for denied cherrypick request merge-to-beta

Comments

@nshahan
Copy link
Contributor

nshahan commented Feb 22, 2023

Commit(s) to merge

fc2c926

Target

beta and stable

Prepared changelist for beta/stable

Issue Description

We updated the configurations for running test builders in the SDK repo. There are accompanying changes in the infrastructure but that config is outside of the SDK repo and is the same across main, beta, and stable branches.

What is the fix

Changes to the DDC test and builder configurations that work with the infrastructure changes.

Why cherry-pick

This cherry pick is only needed if there are other cherry picks selected before the next merge from main into beta or stable. It will help ensure we can still run trybots for DDC.

Risk

low

Issue link(s)

#51481

Extra Info

I'm filing this issue early in preparation. @athomas can link the change to the infrastructure that will trigger the need for this cherry pick when it is ready.

Beta requires cherry picking 2 changes:
https://dart-review.googlesource.com/c/sdk/+/284545 (non-breaking)
https://dart-review.googlesource.com/c/sdk/+/284546 (breaking and requires previous change + change in infra repo)

Stable requires cherry picking 3 changes:
https://dart-review.googlesource.com/c/sdk/+/284542 (non-breaking)
https://dart-review.googlesource.com/c/sdk/+/284543 (non-breaking)
https://dart-review.googlesource.com/c/sdk/+/284544 (breaking and requires previous two changes + change in infra repo)

@nshahan nshahan added the cherry-pick-review Issue that need cherry pick triage to approve label Feb 22, 2023
@kevmoo kevmoo added the area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). label Feb 22, 2023
@athomas
Copy link
Member

athomas commented Feb 27, 2023

For beta, I suggest we don't land this and wait for the next merge to beta which will pick this up.

@athomas athomas added merge-to-beta cherry-pick-denied Label for denied cherrypick request and removed cherry-pick-review Issue that need cherry pick triage to approve labels Feb 28, 2023
@athomas
Copy link
Member

athomas commented Feb 28, 2023

Marking this as denied for beta, we can re-open should this become necessary. Beta 2 will pick up these changes automatically.

@athomas athomas closed this as completed Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). cherry-pick-denied Label for denied cherrypick request merge-to-beta
Projects
None yet
Development

No branches or pull requests

6 participants