Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: octal and binary integer literals #51634

Open
Zekfad opened this issue Mar 5, 2023 · 2 comments
Open

PR: octal and binary integer literals #51634

Zekfad opened this issue Mar 5, 2023 · 2 comments
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues.

Comments

@Zekfad
Copy link

Zekfad commented Mar 5, 2023

fixes dart-lang/language#2708
fixes dart-lang/language#581

Review on: https://dart-review.googlesource.com/c/sdk/+/286922

@lrhn lrhn added the area-front-end Use area-front-end for front end / CFE / kernel format related issues. label Mar 5, 2023
@lrhn
Copy link
Member

lrhn commented Mar 5, 2023

Probably want to decide that we actually want them in the language before doing more about this.
If we do, it needs an experiment flag (and it's probably not going into the 3.0 release, too close to add more features.)

And it will need many more tests.

@Zekfad
Copy link
Author

Zekfad commented Mar 5, 2023

You're totally right. That's prototype implementation, in case if there will be progress in future.

And, honestly, it was also interesting for me personally to see some internals of dart while trying to make this PR working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues.
Projects
None yet
Development

No branches or pull requests

2 participants